Conversation
99d7669 to
347427f
Compare
347427f to
aa97486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.14.8 -> TARGET aa97486)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.14.8...aa97486
Release call:
🟢 GREEN LIGHT TO SHIP No release-blocking regressions were identified; the main user-facing behavior change is intentional, documented, tested, and paired with a minor version bump to 0.15.0.
Scope summary:
src/agents/run_internal/, public exception/export surface insrc/agents/, refusal/error-handler tests, docs forerror_handlers, version metadata, and GitHub workflow action pins.Risk assessment (ordered by impact):
Model refusals now surface as
ModelRefusalErrorerror_handlers["model_refusal"].2d40c09caddsModelRefusalError,ItemHelpers.extract_refusal, refusal resolution inexecute_tools_and_side_effects, and changestest_plaintext_agent_hosted_shell_with_refusal_message_is_final_outputinto an exception expectation.src/agents/exceptions.py,src/agents/items.py,src/agents/run_internal/turn_resolution.py,src/agents/run_error_handlers.py,tests/test_max_turns.py,tests/test_run_step_execution.py,docs/running_agents.mduv run pytest tests/test_max_turns.py tests/test_run_step_execution.py tests/test_responses.py -k "refusal or error_handler"and confirm refusal paths either raiseModelRefusalErroror return configured fallback output as expected.Streaming refusal fallback path has positive coverage, but unhandled streaming refusal should be validated
error_handlersinto streamed turn resolution and tests handled streamed refusals, but an explicit no-handler streaming refusal regression test would reduce release risk.run_single_turn_streamednow accepts and forwardserror_handlers;test_streamed_refusal_handler_returns_outputcovers the handled path, while the no-handler streamed refusal path is not directly covered in the changed tests.src/agents/run_internal/run_loop.py,src/agents/run_internal/turn_resolution.py,tests/test_max_turns.pyRunner.run_streamed(...).stream_events()propagatesModelRefusalErrorand terminates cleanly without hanging.Runner API docstrings still mention only
max_turnsforerror_handlersdocs/running_agents.mddocuments"max_turns"and"model_refusal", butsrc/agents/run.pyargument docs still sayerror_handlers: Error handlers keyed by error kind. Currently supports max_turns.src/agents/run.py,docs/running_agents.mdRunnerentry point docstrings to mention both"max_turns"and"model_refusal"before release docs are generated.GitHub workflow action bumps affect release automation, not runtime package behavior
.github/workflows/publish.yml, release-review workflows, PR labeling, and docs update workflows changed action SHAs;pyproject.tomlanduv.lockonly bump package version to0.15.0..github/workflows/publish.yml,.github/workflows/release-pr.yml,.github/workflows/release-pr-update.yml,.github/workflows/pr-labels.yml,.github/workflows/update-docs.ymlNotes:
git tag -l 'v*' --sort=-v:refname | head -n1:v0.14.8.git rev-parse HEAD:aa97486e6e5b3ec69e61da36bf4238fe8c52fde2.git diff --check v0.14.8...aa97486e6e5b3ec69e61da36bf4238fe8c52fde2produced no whitespace/error output.