fix: restore UnixLocal PTY terminal signal defaults#3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes UnixLocal PTY child signal inheritance for terminal-generated interrupts. After #3075 restored
SIGINT, this follow-up centralizes PTY child signal restoration and also resetsSIGQUITtoSIG_DFL, so Ctrl-\ is not ignored when the parent process temporarily ignoresSIGQUIT.The change updates
src/agents/sandbox/sandboxes/unix_local.pyand extendstests/sandbox/test_unix_local.pywith parametrized regression coverage for bothSIGINTandSIGQUIT. There are no untracked files.