fix: filter custom_tool_call types in remove_all_tools handoff filter#3095
Merged
seratch merged 1 commit intoopenai:mainfrom May 4, 2026
Merged
Conversation
remove_all_tools strips hosted tool types from raw input history before a handoff so the next agent does not see the previous agent's tool plumbing. The list omitted custom_tool_call and custom_tool_call_output, so custom tool calls (used by CustomTool / ResponseCustomToolCall) leaked through after a handoff. Add the two types to the filter list and extend test_removes_hosted_tool_types_from_input_history to cover them.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_all_toolsstrips hosted tool types from raw input history before a handoff so the next agent does not see theprevious agent's tool plumbing. The hosted-types list omitted
custom_tool_callandcustom_tool_call_output, socustom tool calls (produced by
CustomTool/ResponseCustomToolCall) leaked through after a handoff.src/agents/extensions/handoff_filters.py.test_removes_hosted_tool_types_from_input_historyto cover the two new types — without the source change thetest fails.
Test plan
uv run pytest tests/test_extension_filters.py— 36 passeduv run ruff check— cleanuv run ruff format --check— clean