Skip to content

Reject string-like values for shell action commands#3096

Closed
mayunlei wants to merge 1 commit intoopenai:mainfrom
mayunlei:fix-shell-call-string-commands
Closed

Reject string-like values for shell action commands#3096
mayunlei wants to merge 1 commit intoopenai:mainfrom
mayunlei:fix-shell-call-string-commands

Conversation

@mayunlei
Copy link
Copy Markdown

@mayunlei mayunlei commented May 3, 2026

Summary:

  • reject str/bytes/bytearray values for shell action commands in coerce_shell_call
  • raise ModelBehaviorError instead of iterating character-by-character
  • add regression coverage for string-like command payloads

Testing:

  • uv run pytest tests/test_shell_call_serialization.py -q

@seratch
Copy link
Copy Markdown
Member

seratch commented May 4, 2026

Closing this in favor of #3092

@seratch seratch closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants