test: cover real Handoff object branch in visualization#3100
Merged
seratch merged 1 commit intoopenai:mainfrom May 4, 2026
Merged
Conversation
Existing visualization tests use Mock(spec=Handoff) for the Handoff branches and real Agent objects for the Agent branches. The isinstance(handoff, Handoff) paths in get_all_nodes / get_all_edges were never exercised against a real Handoff produced by the public handoff() factory. Add a test that builds an Agent with a real Handoff in handoffs and asserts the resulting DOT contains the expected node and edge.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing visualization tests use Mock(spec=Handoff) for Handoff branches and real Agent objects for
Agent branches. The isinstance(handoff, Handoff) paths in get_all_nodes / get_all_edges were never
exercised against a real Handoff produced by the public handoff() factory. Adds a test that builds an
Agent with a real Handoff and asserts the resulting DOT contains the expected node and edge.