Skip to content

fix: #3170 clean up git repo temp clones on failure#3172

Merged
seratch merged 1 commit intoopenai:mainfrom
Aphroq:fix/git-repo-cleanup-on-copy-failure
May 7, 2026
Merged

fix: #3170 clean up git repo temp clones on failure#3172
seratch merged 1 commit intoopenai:mainfrom
Aphroq:fix/git-repo-cleanup-on-copy-failure

Conversation

@Aphroq
Copy link
Copy Markdown
Contributor

@Aphroq Aphroq commented May 7, 2026

Summary

  • Ensure GitRepo.apply() removes its temporary clone directory from the sandbox even when clone/copy phases fail.
  • Add regression coverage for both copy failure and clone failure cleanup paths.

Test plan

  • uv run pytest tests/sandbox/test_entries.py -q
  • bash .agents/skills/code-change-verification/scripts/run.sh

Issue number

Closes #3170

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

@github-actions github-actions Bot added bug Something isn't working feature:sandboxes labels May 7, 2026
@seratch seratch added this to the 0.16.x milestone May 7, 2026
@Aphroq Aphroq changed the title fix: clean up git repo temp clones on failure fix: #3170 clean up git repo temp clones on failure May 7, 2026
@seratch seratch merged commit 6f5fbf6 into openai:main May 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature:sandboxes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitRepo sandbox artifact leaves temporary clone after copy failure

2 participants