Conversation
fd1e288 to
38ae4dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.16.1 -> TARGET 38ae4dd)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.16.1...38ae4dd
Release call:
🟢 GREEN LIGHT TO SHIP No release-blocking regressions found; the main user-facing behavior changes are covered by a minor version bump and targeted tests.
Scope summary:
extra_argshandling, examples auto-run skips, version bump to 0.17.0.Risk assessment (ordered by impact):
Realtime default model changes from
gpt-realtime-1.5togpt-realtime-2src/agents/realtime/openai_realtime.pychangesDEFAULT_REALTIME_MODELtogpt-realtime-2; realtime examples and tests were updated to expectgpt-realtime-2;pyproject.tomlbumps the package to0.17.0.src/agents/realtime/openai_realtime.py,src/agents/realtime/config.py,tests/realtime/test_openai_realtime.py,examples/realtime/**make testsor, time-constrained,pytest tests/realtime/test_openai_realtime.py tests/realtime/test_session_payload_and_formats.py; pass criteria: default connection/session payload tests continue to assertgpt-realtime-2and no realtime regressions fail.Sandbox local artifact sources are now constrained to base dir unless granted
base_dirmust now declareSandboxPathGrant, which is an intentional security hardening but a migration-sensitive behavior change.f47d4869addsextra_path_grantschecks insrc/agents/sandbox/entries/artifacts.pyandsrc/agents/sandbox/capabilities/skills.py; examples were updated to addSandboxPathGrant; tests now assert outside-base rejection and granted-source success.src/agents/sandbox/entries/artifacts.py,src/agents/sandbox/capabilities/skills.py,tests/sandbox/test_entries.py,tests/sandbox/capabilities/test_skills_capability.pypytest tests/sandbox/test_entries.py tests/sandbox/capabilities/test_skills_capability.py; pass criteria: outside-base paths fail withoutside_base_dir, granted paths still materialize, and lazy skill metadata respects grants.Responses
extra_argscollision behavior changed for omitted kwargssrc/agents/models/openai_responses.pynow ignores duplicate keys whose explicit create kwarg is an OpenAI omitted value;tests/models/test_openai_responses.pyadds coverage forcontext_managementsupplied throughextra_args.src/agents/models/openai_responses.py,tests/models/test_openai_responses.pypytest tests/models/test_openai_responses.py -k extra_arg; pass criteria: omitted explicit kwargs allowextra_args, while true duplicate explicit values still raise.Example auto-run behavior now skips more prerequisite-bound examples
examples/run_examples.pyadds sandbox/cloud/Codex examples toDEFAULT_AUTO_SKIP;tests/test_run_examples_script.pyasserts the new skip set and keepsexamples/tools/computer_use.pyenabled.examples/run_examples.py,tests/test_run_examples_script.pypytest tests/test_run_examples_script.py; pass criteria: prerequisite-bound examples remain skipped and the computer-use example remains enabled.Notes:
v0.16.1.38ae4dd8b46547cbb53bc1dcd0610238ba09c094.uvwas not available in this CI shell, so I did not run local verification; this is not a release blocker under the skill gate policy.