fix(handoffs): await on_handoff callables with async __call__#3211
Merged
seratch merged 1 commit intoopenai:mainfrom May 8, 2026
Merged
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handoff(on_handoff=...)accepts any callable, but the dispatch insrc/agents/handoffs/__init__.pydecided whether toawaitbased oninspect.iscoroutinefunction(on_handoff). That predicate returnsFalseforclass instances whose
__call__isasync def, so for callbacks such asthe runtime called
MyHook()(ctx, input), got a coroutine back, and discardedit without awaiting. Result: the user's
on_handoffnever executed and Pythonemitted
RuntimeWarning: coroutine '__call__' was never awaited.The fix mirrors the pattern already used elsewhere in the codebase (e.g.
Handoff._is_enabled,tool.py): invoke the callable, thenawaittheresult iff it's awaitable. Sync callables remain synchronous; native async
functions and async-
__call__instances are now awaited correctly.Test plan
test_callable_class_with_async_dunder_call_is_awaitedcoversboth the
input_type-bearing branch and the no-input branch.pytest tests/test_handoff_tool.py tests/test_handoff_history_duplication.py tests/test_handoff_prompt.py(28 passed).ruff check+ruff format --checkclean on the touched files.mainwith the documented RuntimeWarning before applying the fix.