fix(computer): exclude Computer instances from provider duck-typing#3249
Merged
seratch merged 1 commit intoopenai:mainfrom May 8, 2026
Merged
Conversation
`_is_computer_provider` returned True for any object with a callable `create` attribute. A `Computer`/`AsyncComputer` subclass that happens to define a `create` method (e.g. a user helper) was misclassified as a `ComputerProvider`, causing `resolve_computer` to fail with `AttributeError: ... has no attribute 'dispose'`. Short-circuit by treating resolved computer instances as non-providers.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_computer_providerinsrc/agents/tool.pychecks forComputerProviderviaisinstanceor any object that exposes a callablecreateattribute. A user-definedComputer/AsyncComputersubclass that happens to define acreatemethod (e.g. an internal helper namedcreate_window,create_session, etc., or any helper namedcreate) is misclassified as a provider.When this happens,
resolve_computerenters the provider branch and crashes:at
disposer: ComputerDispose[Any] | None = lifecycle.dispose if lifecycle else None.Fix
Short-circuit
_is_computer_providerfor already-resolvedComputer | AsyncComputerinstances — they are never providers, regardless of whether a subclass exposes acreateattribute.Test plan
test_resolve_computer_with_create_attribute_returns_instancefails onmainwithAttributeErrorand passes with the fix.tests/test_computer_tool_lifecycle.py,tests/test_computer_action.py).