Skip to content

fix: #3270 Validate model retry backoff settings#3272

Merged
seratch merged 1 commit intoopenai:mainfrom
Aphroq:fix/model-retry-delay-validation
May 8, 2026
Merged

fix: #3270 Validate model retry backoff settings#3272
seratch merged 1 commit intoopenai:mainfrom
Aphroq:fix/model-retry-delay-validation

Conversation

@Aphroq
Copy link
Copy Markdown
Contributor

@Aphroq Aphroq commented May 8, 2026

Summary

Reject negative ModelRetryBackoffSettings values during construction or dict coercion. Negative initial_delay, max_delay, and multiplier values can otherwise produce negative retry delays, which the sleep helper treats as immediate retries.

Zero values remain valid explicit configuration.

Test plan

  • ./.venv/bin/python -B -m pytest tests/models/test_model_retry.py
  • bash .agents/skills/code-change-verification/scripts/run.sh

Issue number

Closes #3270

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

@Aphroq Aphroq changed the title Validate model retry backoff settings fix: #3270 Validate model retry backoff settings May 8, 2026
@seratch seratch added this to the 0.17.x milestone May 8, 2026
@seratch seratch merged commit 9a0c07f into openai:main May 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelRetryBackoffSettings accepts negative values that produce invalid retry delays

2 participants