fix: allow empty GitRepo subpaths as repository root#3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes
GitRepo.subpathhandling so an empty string is treated the same as an omitted subpath and copies the repository root.The sandbox GitRepo hardening correctly rejects unsafe or ambiguous subpaths before clone/copy, including parent traversal, absolute paths, Windows-style paths, and
".". However, generated manifests from forms, JSON config, or environment-derived inputs may serialize an omitted optionalsubpathas"". Treating that empty string as invalid creates avoidable compatibility risk without improving the traversal protection, because repository root is already valid whensubpath=None.This change preserves the safety checks for path traversal and non-POSIX subpaths while normalizing
subpath=""to the root-copy behavior. Tests cover the new empty-string root behavior and keep"."rejected as an invalid explicit subpath.