fix: #3333 scope Realtime tool approvals by qualified key#3340
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #3333 Realtime tool approval state for namespaced function tools. Realtime approval items now carry the resolved tool namespace and lookup key, and approval reuse goes through the shared approval-status lookup instead of checking only the bare tool name.
This prevents an always approval for a namespaced tool such as
crm.lookup_accountfrom being reused for a separate barelookup_accounttool, and it keeps always rejection message reuse aligned with the same qualified approval key. The regression coverage uses the publictool_namespace()helper and verifies the runtime approval, pending-call, and rejection-output behavior directly.