Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #3267 OpenAIConversationsSession persistence for hosted tool-call items whose top-level
idis required by the Conversations API.When a Responses run emits items such as
file_search_call, the session persistence sanitizer previously strippedidbefore callingconversations.items.create(), causing the API to reject the saved turn withMissing required parameter: 'items[0].id'. The fix keeps IDs only for Conversations item types that require them, while continuing to strip optional or policy-controlled IDs from messages, function calls, reasoning items, and tool outputs to avoid replaying stale provider IDs.The change also adds focused regression coverage for required-ID item types, optional-ID item types, provider data stripping, and non-dict passthrough behavior.