Skip to content

fix: #3361 honor session settings in AsyncSQLiteSession#3362

Merged
seratch merged 1 commit into
openai:mainfrom
Aphroq:fix/async-sqlite-session-settings-limit
May 11, 2026
Merged

fix: #3361 honor session settings in AsyncSQLiteSession#3362
seratch merged 1 commit into
openai:mainfrom
Aphroq:fix/async-sqlite-session-settings-limit

Conversation

@Aphroq
Copy link
Copy Markdown
Contributor

@Aphroq Aphroq commented May 11, 2026

Summary

Add session_settings support to AsyncSQLiteSession and resolve get_items(limit=None) through the shared session limit helper.

This aligns async SQLite with the other session backends while preserving existing constructor positional compatibility by appending the optional parameter.

Test plan

  • uv run pytest tests/extensions/memory/test_async_sqlite_session.py -q
  • bash .agents/skills/code-change-verification/scripts/run.sh

The focused async SQLite session tests pass on this branch directly. The full shell verification script was run in a local validation checkout where this branch was temporarily combined with the pending tracing shutdown fix, so the tracing atexit cleanup test would not time out.

Issue number

Closes #3361

Checks

  • I've added new tests (if relevant)
  • I've run make lint and make format
  • I've made sure tests pass

@Aphroq Aphroq changed the title Honor session settings in AsyncSQLiteSession fix: #3361 honor session settings in AsyncSQLiteSession May 11, 2026
@seratch seratch added this to the 0.17.x milestone May 11, 2026
@seratch seratch merged commit e3c99d9 into openai:main May 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncSQLiteSession does not support SessionSettings defaults

2 participants