fix: reject relative sandbox workspace roots#3422
Merged
seratch merged 1 commit intoMay 16, 2026
Merged
Conversation
Validate sandbox workspace roots during WorkspacePathPolicy setup so relative roots are rejected before manifest paths are resolved against an ambiguous base.
matthewflint
force-pushed
the
mflint/sandbox-absolute-workspace-root
branch
from
a569204 to
9fa6c96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspacePathPolicy.Why
WorkspacePathPolicymethods are documented and used as absolute sandbox path helpers. Withroot="workspace",normalize_path("file.py")can produceworkspace/file.pyinstead of an absolute sandbox path, weakening the invariant that sandbox paths are rooted under an absolute workspace.Testing
uv run pytest tests/sandbox/test_workspace_paths.pyuv run ruff check src/agents/sandbox tests/sandboxuv run pyright