Skip to content

fix: remove dependency on types-requests#3509

Open
rouge8 wants to merge 1 commit into
openai:mainfrom
rouge8:gh-3507
Open

fix: remove dependency on types-requests#3509
rouge8 wants to merge 1 commit into
openai:mainfrom
rouge8:gh-3507

Conversation

@rouge8
Copy link
Copy Markdown

@rouge8 rouge8 commented May 26, 2026

Summary

Requests 2.34.0 and newer includes inline type hints.

Test plan

make typecheck

Issue number

Fixes #3507.

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

Requests 2.34.0 and newer includes inline type hints.

Fixes openai#3507.
@rouge8 rouge8 marked this pull request as ready for review May 26, 2026 23:05
@seratch seratch changed the title Remove dependency on types-requests fix: remove dependency on types-requests May 26, 2026
@seratch
Copy link
Copy Markdown
Member

seratch commented May 26, 2026

Thanks for sharing this. requests 2.34 is pretty new, so we'd like to hold off removing types-requests at this moment.

@rouge8
Copy link
Copy Markdown
Author

rouge8 commented May 27, 2026

There shouldn't be any behavior changes for any users of the library. Keeping the dependency means that any users of the library can't upgrade requests and have correct type-checking behavior though.

@seratch
Copy link
Copy Markdown
Member

seratch commented May 27, 2026

Yes, you're right. We'll merge this change eventually, but I just wanted to wait and see the adoption for a short period of time.

@seratch seratch added this to the 0.18.x milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on types-requests

2 participants