fix: remove dependency on types-requests#3509
Open
rouge8 wants to merge 1 commit into
Open
Conversation
Requests 2.34.0 and newer includes inline type hints. Fixes openai#3507.
Member
|
Thanks for sharing this. requests 2.34 is pretty new, so we'd like to hold off removing types-requests at this moment. |
Author
|
There shouldn't be any behavior changes for any users of the library. Keeping the dependency means that any users of the library can't upgrade requests and have correct type-checking behavior though. |
Member
|
Yes, you're right. We'll merge this change eventually, but I just wanted to wait and see the adoption for a short period of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requests 2.34.0 and newer includes inline type hints.
Test plan
make typecheckIssue number
Fixes #3507.
Checks
make lintandmake format