Skip to content

Move types-requests to dev dependencies#3537

Open
PeterTianbuhan wants to merge 1 commit into
openai:mainfrom
PeterTianbuhan:codex/types-requests-dev-dependency
Open

Move types-requests to dev dependencies#3537
PeterTianbuhan wants to merge 1 commit into
openai:mainfrom
PeterTianbuhan:codex/types-requests-dev-dependency

Conversation

@PeterTianbuhan
Copy link
Copy Markdown

Summary

Move types-requests out of the published runtime dependency list and into the dev dependency group. Update uv.lock so openai-agents no longer advertises types-requests in requires-dist, while local development still installs it for type-checking.

This addresses #3507: types-requests is a stub package and does not affect runtime behavior. Keeping it in runtime dependencies makes regular installs pull an unnecessary package, and recent requests releases include inline type hints.

Test plan

  • uv lock --check
  • uv tree --no-dev --package openai-agents confirmed no types-requests in the non-dev install tree
  • git diff --check
  • make sync
  • bash .agents/skills/code-change-verification/scripts/run.sh

Issue number

Closes #3507

Checks

  • I've added new tests (not relevant: dependency metadata only)
  • I've added/updated the relevant documentation (not relevant: dependency metadata only)
  • I've run make lint and make format
  • I've made sure tests pass

Copilot AI review requested due to automatic review settings May 31, 2026 10:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Moves types-requests from runtime dependencies to dev dependencies, since type stubs are only needed during development/type-checking.

Changes:

  • Removed types-requests from the main dependencies list.
  • Added types-requests>=2.0, <3 to the dev dependencies list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seratch seratch added the duplicate This issue or pull request already exists label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on types-requests

3 participants