Move types-requests to dev dependencies#3537
Open
PeterTianbuhan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Moves types-requests from runtime dependencies to dev dependencies, since type stubs are only needed during development/type-checking.
Changes:
- Removed
types-requestsfrom the maindependencieslist. - Added
types-requests>=2.0, <3to thedevdependencies list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
types-requestsout of the published runtime dependency list and into the dev dependency group. Updateuv.locksoopenai-agentsno longer advertisestypes-requestsinrequires-dist, while local development still installs it for type-checking.This addresses #3507:
types-requestsis a stub package and does not affect runtime behavior. Keeping it in runtime dependencies makes regular installs pull an unnecessary package, and recentrequestsreleases include inline type hints.Test plan
uv lock --checkuv tree --no-dev --package openai-agentsconfirmed notypes-requestsin the non-dev install treegit diff --checkmake syncbash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3507
Checks
make lintandmake format