-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Add example notebook with Deep Lake vector database #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hi there @logankilpatrick , bumping this up in case it's possible to merge to add Deep Lake to the list of vector databases, we need more open source ones out there:) |
|
hi @ted-at-openai, just noticed you review a similar pr . Would really appreciate you taking a look at this, too, as it has been up there for a while now. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
simonpfish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FayazRahman and @mikayelh. Apologies for the delay in reviewing this PR, and thank you for your contribution.
I just ran through the notebook and noticed a couple of broken links. It also looks like you're using a deprecated langchain api.
Would it also be possible for you guys to fill out our new pull request template? Let us know if you have any feedback on this template!
|
@simonpfish I have updated the PR and the description, hope everything looks good now! |
|
@simonpfish Fixed! |
|
Thanks for the contribution! |



Summary
Added an example notebook that shows how to implement a QA system with LangChain's Deep Lake integration as a vector store and OpenAI embeddings.
Changes
List the major and minor changes.
Motivation
Add a new vector database to the collection, hence expanding the cookbook.
Self Review Checklist
Note: For additional guidelines on writing good documentation, check out What Makes Documentation Good.