-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Add getting started with PolarDB vector database and OpenAI example. #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getting started with PolarDB vector database and OpenAI example. #489
Conversation
|
Looking forward to the merge of PolarDG's submission :) |
|
Thanks for the contribution, and for your patience. I'll review this week. Any feedback you're looking for, in particular? |
|
Thank you for your review. If it can be merged, it is best. Polardb has a large number of global users, and has advantages in vector computing such as EPQ parallelism and shared storage architecture, resulting in significant speed and efficiency in vector computing. If there are any issues that cannot be accepted, I hope you can provide feedback and I will be responsible for repairing them. We are also developing more applications based on OpenAI and Polardb, and we hope to make more and more contributions to you in the future:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the contribution and for your patience for my review.
I have just one change to request. Do you mind taking out the cell that says:
"os.environ['OPENAI_API_KEY'] = 'sk-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'"
In general I don't want to encourage people to write their API keys in code. I think you have a later cell that reads from environment variables that should work. Our Python library also automatically reads from environment variables.
You can optionally link to our API key safety guide if you think it will help people not get stuck on how to set environment variables: https://help.openai.com/en/articles/5112595-best-practices-for-api-key-safety
9a2a108 to
1376745
Compare
|
Thank you for the review. I have followed your suggestions and removed the API keys, providing a link to the instructional manual. In our future code submissions, my team and I will pay even more attention to this aspect. Thank you for your efforts in reviewing once again. |
|
Could you please review whether it is possible to merge the code? Thank you :) |
ted-at-openai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Merging now.
No description provided.