Skip to content

Conversation

@liuchengshan-lcs
Copy link
Contributor

No description provided.

@liuchengshan-lcs
Copy link
Contributor Author

Looking forward to the merge of PolarDG's submission :)

@ted-at-openai ted-at-openai self-requested a review June 21, 2023 19:35
@ted-at-openai ted-at-openai self-assigned this Jun 21, 2023
@ted-at-openai
Copy link
Collaborator

Thanks for the contribution, and for your patience. I'll review this week. Any feedback you're looking for, in particular?

@liuchengshan-lcs
Copy link
Contributor Author

Thank you for your review. If it can be merged, it is best. Polardb has a large number of global users, and has advantages in vector computing such as EPQ parallelism and shared storage architecture, resulting in significant speed and efficiency in vector computing. If there are any issues that cannot be accepted, I hope you can provide feedback and I will be responsible for repairing them. We are also developing more applications based on OpenAI and Polardb, and we hope to make more and more contributions to you in the future:)

Copy link
Collaborator

@ted-at-openai ted-at-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution and for your patience for my review.

I have just one change to request. Do you mind taking out the cell that says:

"os.environ['OPENAI_API_KEY'] = 'sk-xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'"

In general I don't want to encourage people to write their API keys in code. I think you have a later cell that reads from environment variables that should work. Our Python library also automatically reads from environment variables.

You can optionally link to our API key safety guide if you think it will help people not get stuck on how to set environment variables: https://help.openai.com/en/articles/5112595-best-practices-for-api-key-safety

@liuchengshan-lcs liuchengshan-lcs force-pushed the add_getting_started_with_PolarDB_vector_databases branch from 9a2a108 to 1376745 Compare June 24, 2023 02:10
@liuchengshan-lcs
Copy link
Contributor Author

Thank you for the review. I have followed your suggestions and removed the API keys, providing a link to the instructional manual. In our future code submissions, my team and I will pay even more attention to this aspect. Thank you for your efforts in reviewing once again.

@liuchengshan-lcs
Copy link
Contributor Author

Could you please review whether it is possible to merge the code? Thank you :)

@ted-at-openai ted-at-openai self-requested a review July 12, 2023 00:13
Copy link
Collaborator

@ted-at-openai ted-at-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Merging now.

@ted-at-openai ted-at-openai merged commit 238ff54 into openai:main Jul 12, 2023
imran-binhasan added a commit to imran-binhasan/openai-cookbook that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants