feat(api): add WebSocket stream IDs - #861
Conversation
💡 Codex ReviewWhen a ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27792da10e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8c12bfb9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Re-reviewed all changed files and the stable/beta WebSocket stream-ID paths at commit e20237c. The earlier malformed-accessor and factory-serialization issues are resolved, but one substantive validation-contract issue remains in both server-event unions; see the inline comment.
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Re-reviewed the current head and confirmed stable and beta WebSocket stream IDs preserve factory/deserialization behavior, reject malformed values, and are validated consistently by both server-event unions. All previously reported substantive issues are resolved.
Summary
Adds optional WebSocket-only stream_id routing metadata to Responses client events and all server response events. Events sharing a stream ID are processed FIFO and response events echo that identifier.
Source: https://github.com/openai/openai/pull/1282468
OpenAPI commit: 1e5b3b1f1d21b51c5a37d6122c2b3b2d70ef5a1a
Validation