chore(lint): enable prefer-object-spread - #2078
Merged
Merged
Conversation
This was referenced Aug 5, 2026
jbeckwith-oai
approved these changes
Aug 5, 2026
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the immediate stacked diff and cumulative stack interaction. The two object-spread rewrites preserve the source copy/override semantics, the rule is enabled at deny severity, focused parser/stream tests pass locally, Ultracite check passes locally, and exact-head CI is green.
dfedoryshchev
pushed a commit
to dfedoryshchev/openai-node
that referenced
this pull request
Aug 5, 2026
- [x] I understand that this repository is auto-generated and my pull request may not be merged ## Changes being requested - Remove the `no-template-curly-in-string` compatibility exception from `oxlint.config.ts` so the existing Ultracite preset enforces the rule. - No source changes are needed; all checked handwritten files already satisfy the rule. ## Additional context & links - Oxlint cleanup stack, part 1; based on `main`. - Preserves Stainless-generated-file exclusions and the test/example import exception. ### Validation - Ultracite 7.8.4 formatting and lint check. - TypeScript 6.0.3 type check. - Oxlint configuration regression test. - Baseline handwritten Vitest suite: 62 files, 1,454 tests passing. ## Stack openai#2071 👈 this PR openai#2072 openai#2073 openai#2074 openai#2075 openai#2076 openai#2077 openai#2078 openai#2079 openai#2080 openai#2081 openai#2082 openai#2083 openai#2084 openai#2085
HAYDEN-OAI
force-pushed
the
dev/hayden/ultracite-007-no-regex-spaces
branch
from
August 5, 2026 17:42
b030017 to
8a28bcf
Compare
Base automatically changed from
dev/hayden/ultracite-007-no-regex-spaces
to
main
August 5, 2026 17:47
HAYDEN-OAI
force-pushed
the
dev/hayden/ultracite-008-prefer-object-spread
branch
from
August 5, 2026 17:47
f39ccfb to
a2b9041
Compare
HAYDEN-OAI
enabled auto-merge
August 5, 2026 17:47
OkTest Summary❌ Failed for Node SDK PR #2078. SDK merge ( |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
prefer-object-spreadcompatibility exception fromoxlint.config.ts.Additional context & links
Validation
Stack
#2071
#2072
#2073
#2074
#2075
#2076
#2077
#2078 👈 this PR
#2079
#2080
#2081
#2082
#2083
#2084
#2085