Skip to content

chore(lint): enable no-prototype-builtins - #2084

Merged
HAYDEN-OAI merged 15 commits into
mainfrom
dev/hayden/ultracite-014-no-prototype-builtins
Aug 5, 2026
Merged

chore(lint): enable no-prototype-builtins#2084
HAYDEN-OAI merged 15 commits into
mainfrom
dev/hayden/ultracite-014-no-prototype-builtins

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the no-prototype-builtins compatibility exception from oxlint.config.ts.
  • Apply the required safe Ultracite autofixes and focused handwritten-code cleanup.

Additional context & links

  • Oxlint cleanup stack, part 14; stacked on chore(lint): enable radix #2083.
  • Preserves Stainless-generated-file exclusions and the test/example import exception.

Validation

  • Ultracite 7.8.4 formatting and lint check.
  • TypeScript 6.0.3 type check.
  • Complete handwritten Vitest suite.

Stack

#2071
#2072
#2073
#2074
#2075
#2076
#2077
#2078
#2079
#2080
#2081
#2082
#2083
#2084 👈 this PR
#2085

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head db3a966 against immediate base fae4319. The no-prototype-builtins remediation preserves behavior while avoiding shadowed/missing prototype methods, and the rule enablement is clean in the cumulative lint stack. Local validation: full Ultracite check passed; AssistantStream test suites passed (41 tests); diff check passed. Exact-head CI is green across lint, build, examples, ecosystem tests, and Node 22/24/26 tests.

dfedoryshchev pushed a commit to dfedoryshchev/openai-node that referenced this pull request Aug 5, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-template-curly-in-string` compatibility exception from
`oxlint.config.ts` so the existing Ultracite preset enforces the rule.
- No source changes are needed; all checked handwritten files already
satisfy the rule.

## Additional context & links

- Oxlint cleanup stack, part 1; based on `main`.
- Preserves Stainless-generated-file exclusions and the test/example
import exception.

### Validation

- Ultracite 7.8.4 formatting and lint check.
- TypeScript 6.0.3 type check.
- Oxlint configuration regression test.
- Baseline handwritten Vitest suite: 62 files, 1,454 tests passing.

## Stack

openai#2071 👈 this PR  
openai#2072  
openai#2073  
openai#2074  
openai#2075  
openai#2076  
openai#2077  
openai#2078  
openai#2079  
openai#2080  
openai#2081  
openai#2082  
openai#2083  
openai#2084  
openai#2085
@HAYDEN-OAI
HAYDEN-OAI force-pushed the dev/hayden/ultracite-013-radix branch from fae4319 to 0556714 Compare August 5, 2026 18:13
Base automatically changed from dev/hayden/ultracite-013-radix to main August 5, 2026 18:17
@openai-sdks

openai-sdks Bot commented Aug 5, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 11.71s for Node SDK PR #2084.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 268ms
tests/chat-completions-create.test.ts ✅ Passed 293ms
tests/chat-completions-stream.test.ts ✅ Passed 201ms
tests/files-content-binary.test.ts ✅ Passed 155ms
tests/files-create-multipart.test.ts ✅ Passed 159ms
tests/files-list-pagination.test.ts ✅ Passed 151ms
tests/initialize-config.test.ts ✅ Passed 163ms
tests/instance-isolation.test.ts ✅ Passed 106ms
tests/models-list.test.ts ✅ Passed 150ms
tests/responses-background-lifecycle.test.ts ✅ Passed 292ms
tests/responses-body-method-errors.test.ts ✅ Passed 500ms
tests/responses-cancel-timeout.test.ts ✅ Passed 249ms
tests/responses-cancel.test.ts ✅ Passed 385ms
tests/responses-compact-retries.test.ts ✅ Passed 257ms
tests/responses-compact.test.ts ✅ Passed 384ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 180ms
tests/responses-create-advanced.test.ts ✅ Passed 331ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.106s
tests/responses-create-errors.test.ts ✅ Passed 295ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 197ms
tests/responses-create-retries.test.ts ✅ Passed 242ms
tests/responses-create-stream-failures.test.ts ✅ Passed 216ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.175s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.636s
tests/responses-create-stream.test.ts ✅ Passed 134ms
tests/responses-create-terminal-states.test.ts ✅ Passed 311ms
tests/responses-create-timeout.test.ts ✅ Passed 260ms
tests/responses-create.test.ts ✅ Passed 212ms
tests/responses-delete.test.ts ✅ Passed 223ms
tests/responses-input-items-errors.test.ts ✅ Passed 202ms
tests/responses-input-items-list.test.ts ✅ Passed 188ms
tests/responses-input-items-options.test.ts ✅ Passed 128ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 326ms
tests/responses-input-tokens-count.test.ts ✅ Passed 325ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.306s
tests/responses-not-found-errors.test.ts ✅ Passed 377ms
tests/responses-parse.test.ts ✅ Passed 242ms
tests/responses-retrieve-retries.test.ts ✅ Passed 272ms
tests/responses-retrieve.test.ts ✅ Passed 329ms
tests/responses-stored-method-errors.test.ts ✅ Passed 760ms
tests/retry-behavior.test.ts ✅ Passed 3.137s
tests/sdk-error-shape.test.ts ✅ Passed 424ms

View OkTest run #31034538915

SDK merge (99bf8f7f94e3) · head (9b6bd2d22f90) · base (6d69d4b7dae7) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI enabled auto-merge August 5, 2026 18:24
@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit dcdd7f1 Aug 5, 2026
25 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-014-no-prototype-builtins branch August 5, 2026 18:28
@openai-sdks openai-sdks Bot mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants