Skip to content

chore(lint): enable jsdoc/check-tag-names - #2147

Merged
HAYDEN-OAI merged 4 commits into
mainfrom
dev/hayden/ultracite-067-jsdoc-check-tag-names
Aug 8, 2026
Merged

chore(lint): enable jsdoc/check-tag-names#2147
HAYDEN-OAI merged 4 commits into
mainfrom
dev/hayden/ultracite-067-jsdoc-check-tag-names

Conversation

@HAYDEN-OAI

@HAYDEN-OAI HAYDEN-OAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Remove the jsdoc/check-tag-names compatibility exception from oxlint.config.ts.
  • Allow Jest's intentional @jest-environment pragma through the rule's definedTags option.

Additional context & links

Validation

  • pnpm lint
  • pnpm exec tsc --pretty false
  • pnpm exec vitest run --config vitest.config.mts --update=none

Stack

#2141
#2143
#2144
#2145
#2146
#2147 👈 this PR
#2148
#2149

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSDoc rule activation, custom Jest tag allowance, full-tree lint behavior, file-size impact, and exact-head CI are clean.

@openai-sdks

openai-sdks Bot commented Aug 8, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 10.183s for Node SDK PR #2147.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 146ms
tests/chat-completions-create.test.ts ✅ Passed 207ms
tests/chat-completions-stream.test.ts ✅ Passed 119ms
tests/files-content-binary.test.ts ✅ Passed 131ms
tests/files-create-multipart.test.ts ✅ Passed 178ms
tests/files-list-pagination.test.ts ✅ Passed 188ms
tests/initialize-config.test.ts ✅ Passed 152ms
tests/instance-isolation.test.ts ✅ Passed 102ms
tests/models-list.test.ts ✅ Passed 127ms
tests/responses-background-lifecycle.test.ts ✅ Passed 236ms
tests/responses-body-method-errors.test.ts ✅ Passed 319ms
tests/responses-cancel-timeout.test.ts ✅ Passed 206ms
tests/responses-cancel.test.ts ✅ Passed 240ms
tests/responses-compact-retries.test.ts ✅ Passed 250ms
tests/responses-compact.test.ts ✅ Passed 227ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 118ms
tests/responses-create-advanced.test.ts ✅ Passed 164ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.115s
tests/responses-create-errors.test.ts ✅ Passed 206ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 134ms
tests/responses-create-retries.test.ts ✅ Passed 276ms
tests/responses-create-stream-failures.test.ts ✅ Passed 225ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.157s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.429s
tests/responses-create-stream.test.ts ✅ Passed 104ms
tests/responses-create-terminal-states.test.ts ✅ Passed 212ms
tests/responses-create-timeout.test.ts ✅ Passed 200ms
tests/responses-create.test.ts ✅ Passed 135ms
tests/responses-delete.test.ts ✅ Passed 240ms
tests/responses-input-items-errors.test.ts ✅ Passed 167ms
tests/responses-input-items-list.test.ts ✅ Passed 172ms
tests/responses-input-items-options.test.ts ✅ Passed 122ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 230ms
tests/responses-input-tokens-count.test.ts ✅ Passed 235ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.179s
tests/responses-not-found-errors.test.ts ✅ Passed 266ms
tests/responses-parse.test.ts ✅ Passed 151ms
tests/responses-retrieve-retries.test.ts ✅ Passed 271ms
tests/responses-retrieve.test.ts ✅ Passed 193ms
tests/responses-stored-method-errors.test.ts ✅ Passed 528ms
tests/retry-behavior.test.ts ✅ Passed 3.141s
tests/sdk-error-shape.test.ts ✅ Passed 286ms

View OkTest run #31231027324

SDK merge (3a4f74fb4e3d) · head (c8929ace75f8) · base (8862525cfcaf) · OkTest (91635c6a2723)

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit f7e60a9 Aug 8, 2026
47 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the dev/hayden/ultracite-067-jsdoc-check-tag-names branch August 8, 2026 00:50
@openai-sdks openai-sdks Bot mentioned this pull request Aug 8, 2026
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
…2143)

- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/consistent-existence-index-check` compatibility
exception from `oxlint.config.ts`.
- Normalize the 3 existing handwritten-code `findIndex()` existence
checks to compare with `-1`.

## Additional context & links

- Oxlint cleanup stack, part 63; stacked on
openai#2141.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143 👈 this PR
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `unicorn/prefer-bigint-literals` compatibility exception
from `oxlint.config.ts`.
- Replace the 3 existing test-only `BigInt()` calls with equivalent
bigint literals.

## Additional context & links

- Oxlint cleanup stack, part 64; stacked on
openai#2143.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144 👈 this PR
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-lonely-if` compatibility exception from
`oxlint.config.ts`.
- Flatten the 3 existing handwritten-code `else { if }` branches without
changing their conditions or bodies.

## Additional context & links

- Oxlint cleanup stack, part 65; stacked on
openai#2144.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145 👈 this PR
openai#2146
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-empty` compatibility exception from `oxlint.config.ts`.
- Document the intent of the 3 existing empty catch blocks without
changing control flow.

## Additional context & links

- Oxlint cleanup stack, part 66; stacked on
openai#2145.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146 👈 this PR
openai#2147
openai#2148
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-useless-escape` compatibility exception from
`oxlint.config.ts`.
- Remove the 3 redundant escapes while preserving the email regex
character-class semantics.

## Additional context & links

- Oxlint cleanup stack, part 68; stacked on
openai#2147.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148 👈 this PR
openai#2149
euntaek-hong pushed a commit to wrongbutworks/openai-node that referenced this pull request Aug 9, 2026
- [x] I understand that this repository is auto-generated and my pull
request may not be merged

## Changes being requested

- Remove the `no-throw-literal` compatibility exception from
`oxlint.config.ts`.
- Wrap the 3 existing thrown strings in `Error` while preserving their
messages.

## Additional context & links

- Oxlint cleanup stack, part 69; stacked on
openai#2148.
- Preserves generated-file exclusions and repository-specific import
policy.

### Validation

- `pnpm lint`
- `pnpm exec tsc --pretty false`
- `pnpm exec vitest run --config vitest.config.mts --update=none`

## Stack

openai#2141
openai#2143
openai#2144
openai#2145
openai#2146
openai#2147
openai#2148
openai#2149 👈 this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants