Fix playAudio for Response streams#1952
Merged
HAYDEN-OAI merged 4 commits intoJun 25, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb2dc04427
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
approved these changes
Jun 25, 2026
Contributor
|
hey @fallintoplace, thanks so much for the fix and for your patience while we worked through the stream compatibility details! we’ve got both the web and node stream paths covered now, including clean error handling. merging this now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readable.fromWeb()before piping them toffplay.Responseand mockedffplaystdin.Why
playAudio(response)treatedResponse.bodyas a Node stream and called.pipe()directly. Native fetch responses expose a WebReadableStream, so.pipe()is not available and playback fails at runtime.Validation
./node_modules/.bin/jest tests/helpers/audio.test.ts --runInBand./node_modules/.bin/prettier --check src/helpers/audio.ts tests/helpers/audio.test.ts./node_modules/.bin/eslint src/helpers/audio.ts tests/helpers/audio.test.ts./node_modules/typescript/bin/tsc./scripts/build