Skip to content

chore: migrate to forked steady - #3795

Merged
apcha-oai merged 5 commits into
mainfrom
apcha/migrate-forked-steady
Sep 4, 2026
Merged

chore: migrate to forked steady#3795
apcha-oai merged 5 commits into
mainfrom
apcha/migrate-forked-steady

Conversation

@apcha-oai

Copy link
Copy Markdown
Contributor

migrate to forked steady

@apcha-oai
apcha-oai requested a review from a team as a code owner September 3, 2026 23:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T00:40:00.073278Z fa24ffb New commits
🔒 Security Review Completed 2026-09-04T00:41:06.285841Z fa24ffb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

36 mixed files remain; 0 existing customizations changed.

Compared 88391abf981dfa24ffbf5060. Generated baselines verified.

36 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/responses_client_event.py
  • src/openai/types/responses/responses_client_event_param.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • tests/api_resources/test_videos.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33822556742 --repo openai/openai-python \
  --name castiron-custom-code-33822556742-1 --dir /tmp/castiron-custom-code-33822556742-1
git apply --stat /tmp/castiron-custom-code-33822556742-1/custom-code.patch
cat /tmp/castiron-custom-code-33822556742-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 88391abf981df3ea395ca1b5bf55ec6a4011ea93 fa24ffbf5060fa14f6fc1f1d0ed50ff3e81dd0d0
python3 scripts/castiron/custom_code_report.py report \
  --base 88391abf981df3ea395ca1b5bf55ec6a4011ea93 \
  --head fa24ffbf5060fa14f6fc1f1d0ed50ff3e81dd0d0 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-fa24ffbf5060
cat /tmp/castiron-custom-code-fa24ffbf5060/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 11.385s for Python SDK PR #3795.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 221ms
tests/chat-completions-create.test.ts ✅ Passed 294ms
tests/chat-completions-stream.test.ts ✅ Passed 126ms
tests/files-content-binary.test.ts ✅ Passed 245ms
tests/files-create-multipart.test.ts ✅ Passed 217ms
tests/files-list-pagination.test.ts ✅ Passed 160ms
tests/initialize-config.test.ts ✅ Passed 179ms
tests/instance-isolation.test.ts ✅ Passed 195ms
tests/models-list.test.ts ✅ Passed 206ms
tests/responses-background-lifecycle.test.ts ✅ Passed 264ms
tests/responses-body-method-errors.test.ts ✅ Passed 313ms
tests/responses-cancel-timeout.test.ts ✅ Passed 260ms
tests/responses-cancel.test.ts ✅ Passed 204ms
tests/responses-compact-retries.test.ts ✅ Passed 310ms
tests/responses-compact.test.ts ✅ Passed 321ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 147ms
tests/responses-create-advanced.test.ts ✅ Passed 250ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.209s
tests/responses-create-errors.test.ts ✅ Passed 240ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 329ms
tests/responses-create-retries.test.ts ✅ Passed 315ms
tests/responses-create-stream-failures.test.ts ✅ Passed 124ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 225ms
tests/responses-create-stream-wire.test.ts ✅ Passed 3.736s
tests/responses-create-stream.test.ts ✅ Passed 231ms
tests/responses-create-terminal-states.test.ts ✅ Passed 258ms
tests/responses-create-timeout.test.ts ✅ Passed 222ms
tests/responses-create.test.ts ✅ Passed 299ms
tests/responses-delete.test.ts ✅ Passed 211ms
tests/responses-input-items-errors.test.ts ✅ Passed 300ms
tests/responses-input-items-list.test.ts ✅ Passed 386ms
tests/responses-input-items-options.test.ts ✅ Passed 274ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 255ms
tests/responses-input-tokens-count.test.ts ✅ Passed 228ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.9s
tests/responses-not-found-errors.test.ts ✅ Passed 258ms
tests/responses-parse.test.ts ✅ Passed 391ms
tests/responses-retrieve-retries.test.ts ✅ Passed 261ms
tests/responses-retrieve.test.ts ✅ Passed 193ms
tests/responses-stored-method-errors.test.ts ✅ Passed 571ms
tests/retry-behavior.test.ts ✅ Passed 3.204s
tests/sdk-error-shape.test.ts ✅ Passed 297ms

View OkTest run #33822536347

SDK merge (9bf2a24b6e12) · head (fa24ffbf5060) · base (88391abf981d) · OkTest (2b1bdfd25e98)

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: the atomic publisher is not safe under concurrent Windows/Git Bash bootstraps. only treats and as contention, but Node's directory rename can report or when another process wins. Because this change explicitly advertises Windows support, please handle those codes as contention only when the destination now exists, then rely on to authenticate the winner. Please add focused concurrent-publication coverage.

@jbeckwith-oai
jbeckwith-oai dismissed their stale review September 4, 2026 00:12

Superseded by corrected review text.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: the atomic publisher is not safe under concurrent Windows and Git Bash bootstraps. The publish_directory helper only treats EEXIST and ENOTEMPTY as contention, but Node directory rename can report EPERM or EACCES when another process wins. Because this change explicitly advertises Windows support, please handle those codes as contention only when the destination now exists, then rely on steady_verify to authenticate the winner. Please add focused concurrent-publication coverage.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the requested fix. Concurrent publication now accepts Windows loser-race errors only when a real non-symlink destination exists, and the caller still authenticates the published winner. The focused publication test is wired into CI, HTTPS-only redirects are enforced, and exact-head checks are green.

@apcha-oai
apcha-oai added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit b24aeda Sep 4, 2026
26 checks passed
@apcha-oai
apcha-oai deleted the apcha/migrate-forked-steady branch September 4, 2026 01:28
@openai-sdks openai-sdks Bot mentioned this pull request Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants