feat(api): correct function argument completion event fields (openapi-545) - #3801
Conversation
Castiron-Internal-PR: openai/openai-python-internal#82 Castiron-Source-SHA: 0004bccd015a0c8c73534d7ac1cd74cf4801690b Castiron-Public-Base-SHA: 88b4d43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 36 mixed files remain; 0 existing customizations changed. Compared 36 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33913984259 --repo openai/openai-python \
--name castiron-custom-code-33913984259-1 --dir /tmp/castiron-custom-code-33913984259-1
git apply --stat /tmp/castiron-custom-code-33913984259-1/custom-code.patch
cat /tmp/castiron-custom-code-33913984259-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 88b4d4341af38e84784221d73c175f2088fa6b85 fae5fca6e3cc260fdbcd8fdb47408d39ad870232
python3 scripts/castiron/custom_code_report.py report \
--base 88b4d4341af38e84784221d73c175f2088fa6b85 \
--head fae5fca6e3cc260fdbcd8fdb47408d39ad870232 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-fae5fca6e3cc
cat /tmp/castiron-custom-code-fae5fca6e3cc/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
This keeps the generated Python surface aligned with the actual wire contract: response.function_call_arguments.done no longer requires a name field the server does not promise, while item_id remains the stable correlation key for the owning function-call item. Applying the change to both stable and beta schemas avoids a subtle split where one parser would still reject a valid event. The scope looks correct and I don't see a blocker.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The stable and beta Responses done-event models now match the corrected server contract, while function-call item names and Realtime models remain unchanged. The breaking-change check is the expected intentional field removal described in the PR; the remaining CI is green.
Summary
Removes the name model field from response.function_call_arguments.done to match the API response.
Changes