Skip to content

fix: handle null response.output in parse_response #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gavin913-lss wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: handle null response.output in parse_response #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openai/lib/_parsing/_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def parse_response(
) -> ParsedResponse[TextFormatT]:
output_list: List[ParsedResponseOutputItem[TextFormatT]] = []

for output in response.output:
for output in response.output or []:
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve streamed output when final payload omits it

When the streaming response.completed event has event.response.output == None (the scenario described by this fix), this fallback makes parse_response() build a final ParsedResponse with output=[]. In the streaming path, ResponseStreamState.accumulate_event() calls parse_response(response=event.response) for response.completed instead of parsing the accumulated snapshot, so get_final_response() and the emitted completed event lose all output items/text/tool calls that arrived via earlier response.output_item.added and delta events. This avoids the crash but turns valid streamed responses into empty final responses; the fallback should preserve the accumulated snapshot or otherwise not replace missing final output with an empty list.

Useful? React with 👍 / 👎.

if output.type == "message":
content_list: List[ParsedContent[TextFormatT]] = []
for item in output.content:
Expand Down