fix: preserve binary multipart stream reads - #354
Merged
Conversation
jbeckwith-oai
marked this pull request as ready for review
August 10, 2026 19:22
Contributor
This was referenced Aug 10, 2026
apcha-oai
reviewed
Aug 10, 2026
apcha-oai
approved these changes
Aug 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO#read(max_len, out_string)byte limits, buffering, EOF, negative-length, and output-buffer semantics for Enumerator-backed bodiesIOandStringIOdelegation, including implicitto_intlength conversionThis fixes #317 and consolidates the complete behavior needed from #275, #294, and #324 on the current SDK-owned
ReadIOAdapterimplementation.Ownership
This is handwritten SDK runtime behavior introduced as an SDK-owned component in #345. It does not change OpenAPI inputs, Castiron facts, renderer rules, templates, or generator configuration.
Validation
mise exec ruby@4.0.6 -- ./scripts/test— 531 runs, 1,736 assertions, 0 failuresmise exec ruby@4.0.6 -- bundle exec rake lint— RuboCop, Sorbet, and 1,211 RBS files cleanmise exec ruby@4.0.6 -- bundle exec rake build:gemStringIO