feat: add HTTP response observability - #365
Merged
Merged
Conversation
Contributor
HAYDEN-OAI
approved these changes
Aug 11, 2026
HAYDEN-OAI
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the response-metadata propagation, client-scoped logging/retry API, redaction paths, stream lifecycle behavior, and typing surfaces at the current head. The prior redaction/stream concerns are addressed and I found no substantive issues.
Co-authored-by: Kurtis Tamulonis <kurttamulonis@gmail.com>
jbeckwith-oai
force-pushed
the
codex/http-observability
branch
from
August 11, 2026 22:25
19e1f3d to
38ee0dd
Compare
jbeckwith-oai
enabled auto-merge
August 11, 2026 22:25
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_responseon top-level models, pages, raw streams, and streaming helpersOPENAI_LOG, credential redaction, bounded body logging, retry timing, and stream-safe lifecycle loggingOpenAI::RetryEventcallbacks for observing retries before their delayAPI
Observability configuration belongs to
OpenAI::Client, so it behaves consistently with both the default and custom HTTP transports. This deliberately does not add a raw-response wrapper or generated per-resource methods. Response metadata, retries, logging, transports, and stream attachment remain Ruby overlay concerns.The narrow generated
OpenAI::Clientconstructor counterpart is open in https://github.com/openai/openai/pull/1277393.The independently generated
timeout: nilfix remains in #363. It merges cleanly with this branch, and the composed tree passes the complete Ruby test and lint suites.Closes #242.
Closes #306.
Consolidates and supersedes the implementation work from #262 and #359. The response metadata work originated with @ktamulonis.
Validation