Skip to content

docs: fix wording in Sorbet example comment#259

Closed
Rohan5commit wants to merge 1 commit into
openai:mainfrom
Rohan5commit:docs/fix-demo-sorbet-typo-20260326
Closed

docs: fix wording in Sorbet example comment#259
Rohan5commit wants to merge 1 commit into
openai:mainfrom
Rohan5commit:docs/fix-demo-sorbet-typo-20260326

Conversation

@Rohan5commit

Copy link
Copy Markdown
Contributor

Summary

Fix the wording in the Sorbet example comment in examples/demo_sorbet.rb.

Related issue

N/A

Guideline alignment

Validation

  • Not run; example comment-only change.

@Rohan5commit Rohan5commit requested a review from a team as a code owner March 26, 2026 10:52
Copilot AI review requested due to automatic review settings March 26, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a Sorbet-related explanatory comment in the Ruby SDK’s Sorbet demo to improve readability and correctness without changing any executable code.

Changes:

  • Adjusted wording/punctuation in a comment to correct “infact” → “in fact” and improve clarity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Contributor

Thanks again @Rohan5commit for catching this and opening the fix. I opened #290 from an openai/openai-ruby branch with the same change and preserved your original commit authorship there.

Closing this PR in favor of #290, and we appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants