Skip to content

Tighten JSONL content type matching#277

Open
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/jsonl-content-type-regex
Open

Tighten JSONL content type matching#277
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/jsonl-content-type-regex

Conversation

@fallintoplace
Copy link
Copy Markdown

Summary

  • anchor JSONL_CONTENT to JSONL media types under application/
  • allow content-type parameters such as ; charset=utf-8
  • make matching case-insensitive for media type casing
  • add regression coverage for false positives like text/plain; name=jsonl and foojsonlbar

Fixes #276.

Test plan

  • bundle exec rake TEST=test/openai/internal/util_test.rb test
  • bundle exec rake lint

@fallintoplace fallintoplace marked this pull request as ready for review May 19, 2026 17:41
@fallintoplace fallintoplace requested a review from a team as a code owner May 19, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSONL content type matcher accepts unrelated strings

1 participant