Skip to content

Retain issue roots in explicit workspaceWrite policies#58

Open
danielmcauley wants to merge 3 commits into
mainfrom
dev/dtm/workspacewrite-implicit-issue-root
Open

Retain issue roots in explicit workspaceWrite policies#58
danielmcauley wants to merge 3 commits into
mainfrom
dev/dtm/workspacewrite-implicit-issue-root

Conversation

@danielmcauley
Copy link
Copy Markdown

@danielmcauley danielmcauley commented Apr 14, 2026

Context

Ensure explicit workspaceWrite sandbox policies keep the current issue workspace writable while still allowing extra writable roots like linked-worktree .git metadata.

TL;DR

Keep the issue workspace in explicit workspaceWrite roots and update the launcher follow-up contract.

Summary

  • prepend the current issue workspace to explicit workspaceWrite policies at runtime
  • keep non-workspaceWrite sandbox policies unchanged
  • update config, app-server, and runtime tests for the new contract
  • document the behavior in the Symphony README and SPEC

Alternatives

  • keep passing explicit policies through unchanged, but that forces callers to grant broad workspace roots
  • rely on cwd being writable implicitly, but current runtime/tests model explicit writableRoots as authoritative

Test Plan

  • make -C elixir all
  • cd /Users/dtm/code/symphony/elixir && mise exec -- mix test test/symphony_elixir/app_server_test.exs test/symphony_elixir/workspace_and_config_test.exs test/symphony_elixir/core_test.exs
  • cd /Users/dtm/code/symphony/elixir && mise exec -- mix specs.check

@airhorns
Copy link
Copy Markdown

I hit this issue as well and an agent made a similar fix

jimoosciuc

This comment was marked as low quality.

Copy link
Copy Markdown

@gpt-cmdr gpt-cmdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — dual-approved, merging.

chihsuan added a commit to Automattic/symphony that referenced this pull request May 15, 2026
RSM-3010 Guard Codex action approvals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants