Skip to content

Use a rollback strategy with single engine in tests - #683

Merged
GianlucaFicarelli merged 18 commits into
mainfrom
single_engine_in_tests
Jul 31, 2026
Merged

Use a rollback strategy with single engine in tests#683
GianlucaFicarelli merged 18 commits into
mainfrom
single_engine_in_tests

Conversation

@GianlucaFicarelli

@GianlucaFicarelli GianlucaFicarelli commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Use a single engine in tests to avoid truncating tables after each test.

Local execution:

make destroy
time make test-local

- commit 178098e5 (main):
1081 passed, 29 warnings in 266.58s (0:04:26) 
user=137.55s system=8.08s cpu=50% total=4:46.69

- commit bf31c6b4 (PR)
1081 passed, 29 warnings in 168.89s (0:02:48)
user=133.22s system=6.28s cpu=74% total=3:07.74

CI execution:


- commit 178098e5 (main):
1081 passed, 29 warnings in 532.17s (0:08:52)
https://github.com/openbraininstitute/entitycore/actions/runs/30009134111/job/89212447652

- commit 84bfe2c7 (PR, intermediate commit)
1081 passed, 29 warnings in 403.45s (0:06:43)
https://github.com/openbraininstitute/entitycore/actions/runs/30110409413/job/89538236571

- commit b066a5e8 (PR, last commit)
1083 passed, 29 warnings in 425.86s (0:07:05)
https://github.com/openbraininstitute/entitycore/actions/runs/30269625501/job/89988649102?pr=683

@GianlucaFicarelli GianlucaFicarelli self-assigned this Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.84% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/application.py 96.15% <100.00%> (+0.07%) ⬆️
app/db/model.py 99.15% <ø> (ø)
app/db/session.py 78.04% <100.00%> (+1.73%) ⬆️
app/dependencies/db.py 86.66% <100.00%> (-13.34%) ⬇️
app/queries/common.py 98.24% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread app/db/model.py Outdated
Comment thread app/dependencies/db.py
Comment thread tests/conftest.py
@GianlucaFicarelli GianlucaFicarelli changed the title WIP Single engine in tests Single engine in tests Jul 27, 2026

@eleftherioszisis eleftherioszisis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

GianlucaFicarelli and others added 8 commits July 30, 2026 17:34
* origin/main:
  Move agent rules source to AGENTS.md and sync to Amazon Q and Claude. (#691)
  Change AdminContextDep to UserContextDep for Person, Organization, Consortium create (#688) (#690)
  Strict update schemas: forbid extras and merge exclusions (#687)
  Improve README for exporting data (#684)
* origin/main:
  Add recording_arrays relationship to Simulation (#689)
@GianlucaFicarelli
GianlucaFicarelli enabled auto-merge (squash) July 31, 2026 12:50
@GianlucaFicarelli GianlucaFicarelli changed the title Single engine in tests Use a rollback strategy with single engine in tests Jul 31, 2026
@GianlucaFicarelli
GianlucaFicarelli merged commit d1abcfd into main Jul 31, 2026
1 check passed
@GianlucaFicarelli
GianlucaFicarelli deleted the single_engine_in_tests branch July 31, 2026 12:57
GianlucaFicarelli added a commit that referenced this pull request Jul 31, 2026
* origin/main:
  Use a rollback strategy with single engine in tests (#683)
  Add release and deploy workflows to agent rules (#692)
  Add recording_arrays relationship to Simulation (#689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants