Modernize redux: aclDetailsSlice - #251
Merged
Arnei merged 5 commits intoFeb 28, 2024
Merged
Conversation
Turns out even more of the parameters for the addNotification function in the notificationThunks are perfectly optional.
Fixes a "can't access lexical declaration 'X' before initialization" error, by resolving a kind of circular dependency.
Switching to redux toolkit for getting details for the acl modal.
owi92
reviewed
Feb 15, 2024
Contributor
There was a problem hiding this comment.
acl stuff also appears to be working. (See #242 (review) for more info on these approvals)
edit: whoops this should be an approval.
owi92
approved these changes
Feb 15, 2024
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #213.
Switching to redux toolkit for getting details for the acl modal.