Replace react-smooth-dnd with react-beautiful-dnd - #276
Merged
Conversation
While react-smooth-dnd works perfectly fine, it is also unmaintained and will cause problems when updating to new major versions of react. This switches to a currently maintained library, which is a lot more boilerplate, but also designed for our use case (the list where you can edit which columns are displayed in a table and in what order). Also fixes a bug in the EditTable modal where changes made to the sorting (without saving) would revert themselves after a couple seconds.
Arnei
added
type:bug
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #196.
While react-smooth-dnd works perfectly fine, it is also unmaintained and will cause problems when
updating to new major versions of react. This
switches to a currently maintained library, which is a lot more boilerplate, but also designed for our
use case (the list where you can edit which columns are displayed in a table and in what order).
Also fixes a bug in the EditTable modal where changes made to the sorting (without saving) would revert
themselves after a couple seconds.