Skip to content

Fix wizard stepper that drifts out of window#644

Merged
Arnei merged 2 commits intoopencast:mainfrom
marwyg:fix/issue-612-framing-problems-in-dialogs
Apr 2, 2025
Merged

Fix wizard stepper that drifts out of window#644
Arnei merged 2 commits intoopencast:mainfrom
marwyg:fix/issue-612-framing-problems-in-dialogs

Conversation

@marwyg
Copy link
Copy Markdown
Member

@marwyg marwyg commented Jun 5, 2024

Fixes the wizard steps that are going out of the window in #612.

The text of the wizard steps include word breaking in non blank spaces now. I don't know if this is a good solution, what do you think?

@marwyg marwyg added the bugbash label Jun 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/644/2025-03-31_09-10-44/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-644

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-644

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@marwyg
Copy link
Copy Markdown
Member Author

marwyg commented Jun 5, 2024

This is how it looks with the change:

grafik

and here with even one more step:

grafik

@marwyg marwyg added the type:visual-clarity Improves UI readability label Jun 5, 2024
@Arnei Arnei requested review from Arnei June 5, 2024 13:26
Copy link
Copy Markdown
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we will have to accept that we only have two lines for our text:

Bildschirmfoto vom 2024-06-05 15-33-19

Comment thread src/styles/components/_steps.scss Outdated
Comment thread src/styles/components/_steps.scss Outdated
@kruemelm0nsta
Copy link
Copy Markdown

maybe we could work on the wordbreaking? (minor priority)

@marwyg
Copy link
Copy Markdown
Member Author

marwyg commented Jun 6, 2024

So I tested the CSS changes again after Arnes comments and maybe it would be better to just remove the wordbreaking? I added one extra wizard step with a long text and it still works without wordbreaking:

grafik

So there is room for one additional step currently and if in the future someone should add more steps, maybe this person can deal with the styling then? I tried to test some languages, but when clicking on the above link, there seem only 3 languages work? German, English, Dutch?

@kruemelm0nsta
Copy link
Copy Markdown

for the translation issue @ziegenberg is on it

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Jun 6, 2024

So I tested the CSS changes again after Arnes comments and maybe it would be better to just remove the wordbreaking? I added one extra wizard step with a long text and it still works without wordbreaking:

grafik

Not fond of this personally, as we have to sacrifice the even spacing between the buttons for it. But I'll gladly let people outvote me on that.

@marwyg
Copy link
Copy Markdown
Member Author

marwyg commented Jun 14, 2024

Even spacing sounds good, too :) We also can leave it as it is. That's fine by me.

@lkiesow lkiesow removed the bugbash label Jul 2, 2024
@ziegenberg
Copy link
Copy Markdown
Member

Translation issue should be fixed by now.

Copy link
Copy Markdown
Member

@JulianKniephoff JulianKniephoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging this up with another small nitpick, and the question to the participants: Can this go in once this is fixed? The discussion that resulted from this seems a bit out of scope. 🤔

Comment thread src/styles/components/_steps.scss
@JulianKniephoff JulianKniephoff added the discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays label Oct 29, 2024
@Arnei Arnei requested a review from JulianKniephoff March 31, 2025 09:11
@JulianKniephoff
Copy link
Copy Markdown
Member

Should we have issues tracking the open discussion points or are people satisfied with this?

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Apr 1, 2025

Might have to ping the people you want to answer that directly, I think the only one with major critique was me ^^'.

@JulianKniephoff
Copy link
Copy Markdown
Member

Fair 😛

@Arnei Arnei merged commit 39feee3 into opencast:main Apr 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss in dev meeting Pull requests that should be discussed in the dev meeting on tuesdays type:visual-clarity Improves UI readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants