Skip to content

Change color of fa buttons in actions column to have a better contrast ratio - #663

Merged
lkiesow merged 1 commit into
opencast:mainfrom
rlucke:issue-637
Jun 7, 2024
Merged

Change color of fa buttons in actions column to have a better contrast ratio#663
lkiesow merged 1 commit into
opencast:mainfrom
rlucke:issue-637

Conversation

@rlucke

@rlucke rlucke commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Change color of fa buttons in actions column to have a better contrast ratio

fix #637

use another color for better contrast ratio
@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

EDIT(@lkiesow): The ICLA has been filed. Thanks. It may take some time for Apereo to process the ICLA. Feel free to ignore this complaint for now and point others to this comment if anyone asks.

@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/663/2024-06-06_06-52-27/ .
It might take a few minutes for it to become available.

@github-actions

github-actions Bot commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-663

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-663

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@rlucke rlucke added the type:accessibility This would help impaired users label Jun 6, 2024
@lkiesow

lkiesow commented Jun 7, 2024

Copy link
Copy Markdown
Member

Screenshot from 2024-06-07 12-55-23

Looks good → merging…

@lkiesow lkiesow self-assigned this Jun 7, 2024
@lkiesow
lkiesow merged commit 9319913 into opencast:main Jun 7, 2024
@rlucke
rlucke deleted the issue-637 branch June 12, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:accessibility This would help impaired users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action icon contrast too low

3 participants