Conversation
Contributor
Author
|
(ignore the failing test) |
Contributor
Author
|
@hancush I think I'm going to do this next week. #68 (comment) would have gotten caught by flake8 |
Collaborator
|
@fgregg Sounds good, I was planning to work on some docs, over the weekend. |
Contributor
Author
|
@hancush, this is ready for review. I won't bring this into master until we can orchestrate that with opencivicdata/scrapers-us-municipal#179 |
hancush
approved these changes
May 23, 2018
Collaborator
hancush
left a comment
hancush
left a comment
There was a problem hiding this comment.
this looks awesome and squeaky clean!!
Contributor
Author
|
Great when opencivicdata/scrapers-us-municipal#179 is ready, we can pull this in. Can you take care of that PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a pretty nice scraper here, and other people could benefit from it.
This PR removes the dependency on pupa (which is pretty heavy), removes some old, dead code, and flake8s this code.
In order to make this user friendly we need to add documentation, (which we should probably do for ourselves anyway.
relates to #42
closes #44
opencivicdata/scrapers-us-municipal#179 Should be merged in before this PR.