Conversation
fgregg
approved these changes
Apr 19, 2018
Contributor
fgregg
left a comment
fgregg
left a comment
There was a problem hiding this comment.
This seems like a fine fix. I wonder, if we might think about event (and other objects) knowing about their own url.
Collaborator
Author
|
@fgregg, I agree, I'll open an issue! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We lost the definition of
events_urlwhen we broke outapi_events. This defines anevent_urlin the case where we can't find an event in the web interface, squashing https://sentry.io/datamade/scrapers-us-municipal/issues/531815553/