fix(release): configure auth before gateway startup#24
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 656a96a9d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (command.startsWith("ocm service start ")) { | ||
| return true; | ||
| } | ||
| return command.startsWith("ocm start ") && !/(?:^|\s)--no-service(?:\s|$)/.test(command); |
There was a problem hiding this comment.
When a split startup spends most of its time in ocm service install and then ocm service start returns quickly, coldReadyMs and the coldReadyMs threshold now ignore that install duration because this predicate only matches service start (and legacy ocm start). The modified startup scenarios put both commands in the product gateway-start phase, so a slow install/bootstrap step can still produce a passing record with an artificially low cold-start measurement.
Useful? React with 👍 / 👎.
vincentkoc
force-pushed
the
codex/canonical-openai-model-ref
branch
from
656a96a to
84cc2df
Compare
vincentkoc
changed the title
2 participants
No description provided.