fix(web): keep report generation on patched dependencies - #78
Conversation
|
Codex review: needs changes before merge. Reviewed July 28, 2026, 2:55 AM ET / 06:55 UTC. ClawSweeper reviewWhat this changesThe PR upgrades Kova’s Astro-based report site from Astro 6 to Astro 7, refreshes its lockfile, and pins Merge readinessKeep this draft PR open for normal review. The dependency update targets a concrete report-site security concern, but the branch also edits the release-owned changelog and the major Astro upgrade still needs report-output and payload validation on the final head. Priority: P2 Review scores
Verification
How this fits togetherKova generates validation reports and the report site renders those results as static pages, including generated Open Graph images. The site’s package manifest and lockfile determine the build toolchain and image/SVG processing dependencies used to publish those reports. flowchart LR
A[Kova scenario reports] --> B[Report site content pipeline]
B --> C[Astro static-site build]
C --> D[Image and SVG processing]
D --> E[Published report pages]
F[Package manifest and lockfile] --> C
F --> D
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Land the minimal manifest and lockfile upgrade only after removing the release-owned changelog edit and confirming that a representative report build preserves generated pages, OG images, and the payload check on the final head. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR addresses dependency security floors rather than a user-reported runtime reproduction. The supplied PR body identifies the affected report-site dependency graph and lists audit/build checks. Is this the best way to solve the issue? Unclear until final-head output validation is visible: upgrading the direct dependency and constraining vulnerable transitive versions is a maintainable approach, but the release-owned changelog edit should be removed and the major-version build compatibility confirmed. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 417f7010095b. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(web): keep report generation on patched dependencies This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Fixes an issue where Kova's report-site lock retained vulnerable Astro, URL parsing, image processing, CSS, SVG, and build-tool dependencies.
Why This Change Was Made
The report site moves from Astro 6.4 to Astro 7.1 and pins the transitive packages whose upstream ranges still resolve below the published security floors. The existing static-site configuration and content pipeline remain unchanged.
User Impact
Published Kova reports build with patched dependencies and retain the same static pages, generated OG images, and content validation behavior.
Evidence
npm audit --audit-level=low: 0 vulnerabilitiesnpm test: 6 passednpm run check: 0 errorsnpm run build: 18 pages builtnpm run check:web-payload: 1 ok / 0 failgit diff --check