fix(site): keep navigation current and restore section links - #36
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(site): keep navigation current and restore section links This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slow documentation fetch could overwrite a newer page after tab navigation, leaving Notes selected while People was displayed. Give each navigation ownership of its fetch result, including errors and cache writes. The viewer also attempted to navigate to section IDs that Markdown rendering never generated; assign collision-free heading IDs while reserving all explicit article anchors.
Four initial regressions reproduced stale successes, stale failures, same-slug revisits, and missing section targets. The expanded suite additionally covers Unicode fragments, duplicate headings, and explicit heading/non-heading anchors. All 14 Node tests pass. The browser and tests now load the shared
scripts/site.jsdirectly; this removes the brittle HTML-extraction regex flagged by CodeQL, without suppressing any check. Isolated Codex autoreview is scoped-clean at P0–P2 after fixing its explicit-anchor collision finding.Live proof through the real Chrome profile and the retained shared extension relay: delay the People response, navigate to Notes, then let People finish. Before:
hash=#/notes, labeldocs/notes.md, headingPeople. After: the same hash/label retain headingNotes. Navigating to#/imports#sync-preview-onlyfinds and scrolls toSync (preview-only). The screenshots contain only public documentation and synthetic examples.