fix: include UTC date in cross-date review timestamps#438
Conversation
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs maintainer review before merge. Reviewed July 9, 2026, 12:02 AM ET / 04:02 UTC. Summary Reproducibility: yes. Current main formats the UTC side as only Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land the narrow formatter and regression-test change after the draft is marked ready and normal gates remain green. Do we have a high-confidence way to reproduce the issue? Yes. Current main formats the UTC side as only Is this the best way to solve the issue? Yes. The PR preserves same-date concise rendering and adds the UTC date only when the ET and UTC calendar dates differ, with a focused rendering regression test. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7e27e5dc8055. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles) |
|
@clawsweeper re-review |
1 similar comment
|
@clawsweeper re-review |
Summary
Problem
A live ClawSweeper review on openclaw/openclaw#101937 rendered:
Reviewed July 8, 2026, 11:00 PM ET / 03:00 UTC.That is misleading because 11:00 PM ET on July 8, 2026 is 03:00 UTC on July 9, 2026. The UTC side needs its date when the calendar day differs.
Related live-state checks found no duplicate ClawSweeper PR:
gh pr list --repo openclaw/clawsweeper --state open --limit 30 --json number,title,author,headRefName,baseRefName,url,updatedAt,labels,isDraft: only open PR was feat(review): opt-in external CLI engine for offline local review #432, unrelated.gh pr list --repo openclaw/clawsweeper --state merged --limit 20 --json number,title,author,headRefName,mergedAt,url: recent merged PRs were unrelated.gh search prs "timestamp reviewed UTC timezone" --repo openclaw/clawsweeper --state open --json number,title,state,author,url,updatedAt --limit 20: no matches.gh search prs "timestamp reviewed UTC timezone" --repo openclaw/clawsweeper --state closed --json number,title,state,author,url,updatedAt --limit 20: no matches.Implementation
formatReviewFreshnessTimestampnow formats the ET and UTC calendar dates separately. If they match, the UTC side remainsHH:MM UTC; if they differ, the UTC side becomesMonth D, YYYY, HH:MM UTC.Validation
Passed:
pnpm run buildnode --test test\review-comment-rendering.test.ts(19 tests passed)git diff --checkpnpm run build:allpnpm run lintpnpm exec oxfmt --check src/clawsweeper.ts test/review-comment-rendering.test.tscodex -c service_tier=fast review --base origin/mainBroad-check notes:
pnpm run checkreachedtest:unitand failed on Windows host prerequisites unrelated to this diff: defaultbashresolves to WSLC:\Windows\System32\bash.exe, whose distro lacks/bin/bash; after using Git Bash, the remaining unrelated failures were missingjqand two--local-rangetests whose fake.shCodex stubs did not execute on this Windows host.pnpm run test:repairpassed 620 tests and failed 2 target-validation tests because temp target repos tried to spawnC:\Users\marti\AppData\Local\Corepack\shims\pnpmand hitENOENT.pnpm run format:checkreports existing formatting differences across many files; the touched-file format check above passed.Proof
Rendered-output proof from PR head (
f53b4b8cd80679f773dffc1401e7990735845e4e):Redacted terminal transcript showing generated review-comment output from the built renderer:
The focused rendering test now covers both cases:
May 22, 2026, 12:43 AM ET / 04:43 UTC.July 8, 2026, 11:00 PM ET / July 9, 2026, 03:00 UTC.Codex review closeout:
codex -c service_tier=fast review --base origin/mainRisks / Rollout
Risk is limited to the first-line ClawSweeper review freshness text. This does not touch review decisions, labels, gates, workflow files, repair behavior, auth, or merge automation.
User-facing release-note context: ClawSweeper review comments now avoid misleading UTC-only times around ET/UTC date boundaries.
Links
|| 1fallback in channel status display openclaw#101937