test(repair): execute containment worker from isolated cwd#591
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 15, 2026, 10:58 PM ET / July 16, 2026, 02:58 UTC. Summary Reproducibility: not applicable. as a current bug reproduction: #590 already fixed the production failure, while this PR adds focused behavior-level coverage for that resolved path. Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land the narrow behavior-level regression test after ordinary maintainer review so the absolute worker-entry invariant fixed by #590 remains protected. Do we have a high-confidence way to reproduce the issue? Not applicable as a current bug reproduction: #590 already fixed the production failure, while this PR adds focused behavior-level coverage for that resolved path. Is this the best way to solve the issue? Yes. Executing the built entrypoint from an unrelated temporary working directory is the narrowest direct test of the path-resolution invariant, and the existing workflow-text assertion remains useful for checking the invocation wiring. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0a17516dd286. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: test(repair): execute containment worker from isolated cwd This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
Why
The regression coverage added in #590 prevents the workflow from returning to a relative worker path, but it checks the workflow text. This adds behavior-level proof that the worker entrypoint can actually load after the child process changes to the isolated work directory. The prior relative invocation would fail this scenario with
MODULE_NOT_FOUND.Impact
Test-only change. Production containment and security boundaries are unchanged.
Validation
pnpm run check: passed--mode uncommitted): clean, no actionable findingsgit diff --checkpnpm run format:check