Skip to content

fix(repair): remove router Git writer pressure - #813

Merged
vincentkoc merged 1 commit into
mainfrom
fix/comment-router-fanout
Jul 23, 2026
Merged

fix(repair): remove router Git writer pressure#813
vincentkoc merged 1 commit into
mainfrom
fix/comment-router-fanout

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Related: #738

What Problem This Solves

Fixes an issue where every distinct @clawsweeper command entered the serialized state-repository writer even when routing completed in seconds and no repair job changed. During the incident, one router finished command processing in about 20 seconds, then waited over 22 minutes at writer queue position 33 before cancellation.

Why This Change Was Made

Distinct maintainer commands remain independent and lossless. The durable processed-command ledger continues through the append/materializer path; the invocation-only latest scan report is no longer Git-published; and jobs/ enters the Git writer only when a command actually changed durable repair work. The materializer retires the old tracked latest report on its next router batch.

User Impact

Routine status and re-review commands no longer contend for the state Git writer after routing, while commands that genuinely create or update repair jobs retain durable publication.

Evidence

  • Live failure evidence: run 30010373110 routed successfully, then stalled in the state writer until cancellation.
  • 75 focused tests passed.
  • Main and repair TypeScript builds passed.
  • Targeted formatting, lint, git diff --check, and structured autoreview passed with no actionable findings.
  • No SQLite schema or append protocol change.

@vincentkoc
vincentkoc marked this pull request as ready for review July 23, 2026 14:14
@vincentkoc
vincentkoc requested a review from a team as a code owner July 23, 2026 14:14
@clawsweeper

clawsweeper Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(repair): remove router Git writer pressure This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc force-pushed the fix/comment-router-fanout branch from c1cd045 to 7108308 Compare July 23, 2026 14:16
@clawsweeper

clawsweeper Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(repair): remove router Git writer pressure This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc

Copy link
Copy Markdown
Member Author

Addressing the ClawSweeper rank-up move: the release-owned changelog edit is removed, focused workflow/materializer coverage exercises both unchanged and changed jobs/ paths, and fresh autoreview is clean (0.87). I am not creating a synthetic repair job in production solely to prove the changed-jobs branch while publication is critical. After merge I will verify the next no-change router run bypasses the Git writer and inspect the next real job-changing command for durable jobs/ publication.

@vincentkoc
vincentkoc force-pushed the fix/comment-router-fanout branch from 7108308 to bab0dcf Compare July 23, 2026 14:20
@clawsweeper

clawsweeper Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(repair): remove router Git writer pressure This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc merged commit a4e1c02 into main Jul 23, 2026
9 checks passed
@vincentkoc
vincentkoc deleted the fix/comment-router-fanout branch July 23, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant