feat: add local benchmark timing ledger - #455
Conversation
|
@clawsweeper re-review Requesting ClawSweeper review for this new PR. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
ef6178e to
8b739cd
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 8:43 PM ET / 00:43 UTC. Summary Reproducibility: not applicable. this is an additive feature PR, not a bug report. Source and related-issue inspection show the requested surface is new rather than broken existing behavior. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this PR after required checks complete and maintainers are comfortable with the opt-in v1 JSONL/report contract, letting the linked feature issue close through the PR. Do we have a high-confidence way to reproduce the issue? Not applicable: this is an additive feature PR, not a bug report. Source and related-issue inspection show the requested surface is new rather than broken existing behavior. Is this the best way to solve the issue? Yes for the implementation shape after the latest fixes: persistence is opt-in, reports are local-evidence based, delegated timing details are preserved, and provider categories are populated from generated metadata. Final acceptance still needs normal maintainer product review because this adds CLI and storage surface. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 8bd692605598. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
After-fix proof for #455 at Fixes:
Redacted real Docker-backed output: Additional proof: |
Closes #342.
Summary
TimingReportpayloadsrun --timing-record,bench run,bench record, and evidence-awarebench report --json--timing-jsonpayload contractVerification
go test -race ./internal/cligo vet ./...scripts/check-docs.shReal behavior proof
Built the CLI from head
1a62922cand exercised a real Docker-backedlocal-containerworkflow:run --timing-record: one successful observation, automatic lease cleanupbench run --provider local-container --repeats 2 -- true: two observations, zero failures, automatic cleanup after both runsbench report --provider local-container --min-samples 2 --json: three matched successful observations,providerCategory=local-runtime,insufficientEvidence=false,evidence=sufficient_local_samplesThe delegated regression coverage also proves that recording captures provider-authored sync duration, sync phases, and machine metadata;
--timing-jsonremains one final JSON object, and timing JSON is not printed when only recording is requested.