chore(deps): bump age to v1.3.2 - #100
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed August 31, 2026, 2:19 AM ET / 06:19 UTC. ClawSweeper reviewWhat this changesThe PR updates the age encryption dependency to v1.3.2 and refreshes its resolved Go module checksums and unreleased changelog entry. Merge readiness⛔ Blocked until real behavior proof is added - 4 items remain Keep open pending upgrade-safety coverage and real behavior proof: the narrow dependency update changes the encrypted-backup library’s stated input limits, while existing crawlkit validation accepts an unbounded recipient list. Priority: P2 Review scores
Verification
How this fits togetherThe shared backup package encrypts archive shards and files using age before they are stored in a local archive. Restore paths decrypt those artifacts, so dependency acceptance limits affect both backup creation and recovery. flowchart LR
A[Archive data and files] --> B[Backup writer]
B --> C[Age encryption library]
C --> D[Encrypted archive shards]
D --> E[Backup restore]
E --> F[Recovered local data]
Decision needed
Why: The limits harden encrypted-input handling but can make previously accepted configuration or persisted ciphertext fail, and the desired upgrade behavior is a maintainer policy choice. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the upstream hardening only with an explicit upgrade decision, focused boundary/error coverage, clear recovery guidance for affected archives, and redacted evidence from a real backup-and-restore run. Do we have a high-confidence way to reproduce the issue? No high-confidence executed reproduction is available in this review. The case is source-reproducible at medium confidence: crawlkit admits all valid recipients and the PR states that the newly pinned dependency enforces a 1,024-recipient limit. Is this the best way to solve the issue? No—the version bump is not ready by itself because its intentional input hardening has an unaddressed upgrade boundary. A focused compatibility decision, coverage, and real-run evidence are the narrowest maintainable completion path. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 52f0fb12e4d2. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Update
filippo.io/agefrom v1.3.1 to v1.3.2 for upstream fixes and input hardening, refresh the module checksums, and add a changelog entry. This adopts upstream's 2 MiB header and 1,024-recipient limits without changing crawlkit's backup APIs.Validation:
GOWORK=off go mod tidy, unchanged module files after a second tidy,go vet ./..., andgo test -count=1 ./...withGOWORK=off; Codex autoreview clean through P3. Builtcrawlctlpassed help, run, JSON status, and log checks. Real backup API runs wrote and restored encrypted JSONL snapshots and 200,000-byte files across age v1.3.1 → v1.3.2 and v1.3.2 → v1.3.1; wrong identities and truncated ciphertext were rejected. All runtime data used temporary fixtures.