fix(release): verify unified archives and reopen changelog - #161
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 2, 2026, 2:31 PM ET / 18:31 UTC. ClawSweeper reviewWhat this changesThe PR updates the macOS release verifier to accept canonical Merge readinessThis PR is still necessary: current Priority: P3 Review scores
Verification
How this fits togetherThe unified release workflow produces signed macOS archives and declares the release files that belong in them. flowchart LR
A[Unified release workflow] --> B[Signed macOS archive]
B --> C[Downloaded release artifacts]
C --> D[make verify-release]
D --> E[Archive member validation]
E --> F[Signature and notarization checks]
F --> G[Verified public release]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Merge the focused normalization and regression coverage after the remaining required checks complete, preserving the strict four-member archive contract for future release verification. Do we have a high-confidence way to reproduce the issue? Yes—source inspection gives a high-confidence path: create an otherwise valid archive with root Is this the best way to solve the issue? Yes—the proposed one-prefix normalization is the narrowest maintainable repair because it accepts the canonical archive spelling without widening the four-file allowlist or weakening checksum, signature, notarization, architecture, or version checks. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 762f10c51f83. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Summary
Unreleasedchangelog section after the verifiedv0.12.0release./-prefixed tar member paths while retaining the exact four-member archive allowlistThe public release and shared workflow verification were successful. During independent closeout verification, Discrawl's local
make verify-releasehelper rejected the canonical archive layout before reaching its signature checks because it expected unprefixed tar member names. The verifier now strips only one leading./and the root./entry before performing the same exact member comparison; traversal, duplicates, unexpected files, and nested paths still fail.Validation
GOWORK=off go test ./scriptsmake verify-release VERSION=v0.12.0 ARTIFACT_DIR=/private/tmp/discrawl-v0.12.0-verify.GILQA3The downloaded public assets also passed every line of the published
checksums.txt; the live arm64 binary reported0.12.0.