chore(deps): refresh compatible Go dependencies and tooling - #171
chore(deps): refresh compatible Go dependencies and tooling#171steipete wants to merge 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed September 4, 2026, 4:30 AM ET / 08:30 UTC. ClawSweeper reviewWhat this changesUpdates the Go 1.26 patch baseline, SQLite and three indirect dependencies, Docker build tooling, secret scanning, and matching installation documentation. Merge readiness⛔ Blocked before merge - 5 items remain Keep open: the updates are absent from current main and v0.9.4, and both PR descriptions explicitly defer this branch to the still-open integrated candidate. No actionable patch defect was found; the earlier runtime-proof gap remains. Priority: P3 Review scores
Verification
How this fits togetherGitcrawl mirrors GitHub issues and pull requests into a local SQLite archive for search and triage. These dependency and build-tool updates affect the CLI, its archive operations, Docker builds, and repository secret scanning. flowchart LR
A[Go dependencies and build tools] --> B[Gitcrawl CLI and Docker image]
C[GitHub responses] --> B
D[Existing archive] --> E[SQLite storage]
B --> E
E --> F[Search and triage results]
G[Repository changes] --> H[Secret scanning]
Before merge
Agent review detailsSecurityNone. Review metricsNone. Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land one validated dependency set through the integrated candidate, with visible archive-compatibility results and a documented build baseline. Do we have a high-confidence way to reproduce the issue? Not applicable: this maintenance PR does not report a specific existing-behavior bug, and source inspection found no concrete introduced defect. Is this the best way to solve the issue? Yes, the coordinated version updates are a bounded maintenance approach; the explicit integrated landing path avoids independently landing competing toolchain baselines. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 3c9e6d58548f. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
Align source and Docker builds on Go 1.27.1 for CrawlKit 0.14.8, with the source-build minimum and macOS 13 minimum for newly built binaries documented in README, installation docs and the changelog. The documented platform transition is approved for this dependency update. Absorb the compatible updates from #171: SQLite 1.58.0, runewidth, pprof, golden, TruffleHog 3.97.4 and Dockerfile frontend 1.27. Keep SQLite's exact libc 1.75.6 requirement. Apply only the indentation required by the Go 1.27 formatter in application code. Preserve the review-cursor fix and contributor thanks from #169. Full checks pass at 85.6% coverage, including six snapshot targets. Real CLI proof reopens an old archive, syncs through HTTP, searches through FTS, checks SQLite integrity, and preserves existing review rows on malformed cursors. Docker build/runtime and managed CodeQL 2.26.4 with actual Go 1.27.1 pass on the reviewed head. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Absorbed into #170, now merged as 3413039cbab09f778dbbc486f275eaa5e9b3bfb1. Both commits from this branch—1eebb3d75243f471f7bb22d80b4ecce8c4416f69 and 97885c5—were incorporated through normal merges into the reviewed #170 head, bec2e08. The actual squash merge tree exactly matches that reviewed candidate. The integrated version uses the approved Go 1.27.1 baseline and retains SQLite's exact libc 1.75.6 constraint. The integrated candidate passed full checks at 85.6% coverage and actual CLI old-archive reopening, HTTP sync, full-text search, integrity checking, and malformed-cursor preservation tests. Post-merge Linux/macOS CI, Docker build/runtime, managed CodeQL, secret scanning, and docs all passed on the actual merge commit. Closing this PR as absorbed; it has not been merged separately. |
This maintenance candidate has been incorporated into #170 through normal merges. Keep #171 open until the integrated #170 is reviewed and merged; it should not be merged separately.
Refresh the supported Go 1.26 toolchain and compatible dependencies without changing the Go release series. Source builds, Docker, and installation documentation now agree on Go 1.26.8.
Update SQLite to 1.58.0, go-runewidth to 0.0.29, and the current pprof/golden snapshots. Update the Dockerfile frontend from 1.26 to 1.27 and the secret-scanning Action from TruffleHog 3.97.1 to 3.97.4. Other Actions and pinned development tools were checked against upstream metadata and are current.
CrawlKit remains at 0.14.7: #170 requires Go 1.27 and needs a separate decision about the supported build baseline. This change keeps that migration separate from compatible maintenance updates.
SQLite's generated runtime explicitly requires libc 1.75.6. Keep that exact version, with a short comment explaining the constraint. Upstream dependency requirement.
Validation:
integrity_check.make checkpasses with Go 1.26.8 and its matching formatter: tidy, format, vet, govulncheck, deadcode, full suite (85.1% coverage), CLI smoke, release-script tests, and all six snapshot targets. No vulnerabilities found.The final Dockerfile frontend update was independently reviewed at P2 with no findings. The Go source and dependency set retain the complete local proof above; Docker CI validates the updated frontend.
Final-head CI for
97885c502493631916983a60a6bdad963e9b3029is green: Linux/macOS CI, Docker build and runtime smoke, secret scanning, and managed CodeQL. The docs site also builds successfully withnode scripts/build-docs-site.mjs.