feat(slides): add paragraph styling for shapes and cells - #1123
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. Reviewed September 11, 2026, 6:50 PM ET / 22:50 UTC. ClawSweeper reviewWhat this changesAdds a Slides command for paragraph alignment, spacing, indentation, and direction in shapes or individual table cells, with documentation, tests, and safety-profile exclusions. Merge readiness⛔ Needs changes before merge - 1 item remains Keep open: this is a useful, focused addition that current main does not provide as a dedicated command. No blocking correctness or security defect was found. Priority: P2 Review scores
Verification
How this fits togetherThe Slides CLI converts presentation IDs, element targets, and formatting flags into authenticated Google Slides requests. Existing mutation helpers handle dry runs, output, and table revision checks. flowchart TD
A[Presentation and element IDs] --> B[Validate formatting and range]
B --> C{Table cell selected?}
C -->|Yes| D[Validate cell and capture revision]
C -->|No| E[Existing mutation helper]
D --> E
E --> F[Dry-run plan or Google Slides update]
Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Provide one focused paragraph-formatting command that preserves unspecified fields and shares existing authentication, dry-run, and mutation safeguards. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature addition; source confirms the missing dedicated command, and the author reports live Google validation of the new behavior. Is this the best way to solve the issue? Yes: a thin, validated wrapper fits the existing Slides command design and avoids requiring users to construct raw Discovery API requests. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 73d0b9eba394. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Maintainer proof at 53b37d5:
Ready for orchestrator-approved squash; closes #1098 on merge. Release notes are in the final batch notes PR. |
Add
slides paragraph-stylefor alignment, line spacing, paragraph spacing, indentation and direction on shapes or individual table cells. Optional UTF-16 ranges affect intersecting paragraphs; omitted ranges select all text. Only supplied fields are changed, including explicit zero dimensions.Reuse the existing mutation helpers for complete auth-free dry-run plans and normal command guards. Cell targets are validated against the current table and protected by the presentation revision. The supplied baked profiles leave the new mutation disabled.
The built CLI passed live Google checks for range-scoped alignment while preserving the second paragraph, spacing reset to zero, hanging indentation, table-cell alignment/line spacing/direction and invalid-row refusal. The disposable presentation was trashed and verified. Tests cover field masks, wire-level zeros, ranges, validation, cell targeting/revision checks and complete dry-run values. Codex autoreview is clean through P2.
Closes #1098. Thanks @sebsnyk. The changelog entry is reserved for the final notes PR; exact-head CI proof will be posted before handoff.